lexonomy/lexonomy_custom_editor
7
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mt-homonymy-support #2

Manually merged
lexonomy merged 7 commits from mt-homonymy-support into master 2020-08-05 10:04:56 +00:00
Conversation 3 Commits 7 Files Changed 12 +264 -182
matic_t commented 2020-07-16 10:25:30 +00:00
Member
Copy Link
No description provided.
ozbolt was assigned by matic_t 2020-07-16 10:25:31 +00:00
lkavcic was assigned by matic_t 2020-07-16 10:25:31 +00:00
matic_t added 4 commits 2020-07-16 10:25:33 +00:00
matic_t commented 2020-07-16 10:27:48 +00:00
Author
Member
Copy Link

Probably best if both of you check it out.
Ožbolt for prevention and Luka so we both can speed up understanding of whole stack.

Basically we're adding support for the example in vsms1.xml file. It's already in schema so we just had to provide support in editor.

https://lexonomy.cjvt.si/5pdds79p/ - link to plugin used on dictionary

Probably best if both of you check it out. Ožbolt for prevention and Luka so we both can speed up understanding of whole stack. Basically we're adding support for the example in vsms1.xml file. It's already in schema so we just had to provide support in editor. https://lexonomy.cjvt.si/5pdds79p/ - link to plugin used on dictionary
matic_t added 1 commit 2020-07-16 10:46:56 +00:00
matic_t added 1 commit 2020-07-16 10:50:29 +00:00
matic_t added 1 commit 2020-07-16 11:23:09 +00:00
ozbolt commented 2020-07-16 19:54:16 +00:00
Member
Copy Link

First of all, I did not test the code, I just went over the changes.

About the code, there are two mistakes:

  • homonomy_list_getter in common_accessors is only used once. This is fine, but the way I imagined it is that if this kind of functionality is only used once, than implement it inside the class (this time its EditHomonymy). Then later if needed to avoid code duplication refactor stuff out of the class and in common_accessors. But that is fairly subjective point and you can decide to do it another way :)
  • second one, if your IDE does white spaces this way, than create a big commit with only white space changes and than work from there. This is again not so important, but makes git blame and commits themselfs much less readable.

Otherwise, yes, everything looks nice and clean, gg :)

First of all, I did not test the code, I just went over the changes. About the code, there are two mistakes: * `homonomy_list_getter` in `common_accessors` is only used once. This is fine, but the way I imagined it is that if this kind of functionality is only used once, than implement it inside the class (this time its `EditHomonymy`). Then later if needed to avoid code duplication refactor stuff out of the class and in common_accessors. But that is fairly subjective point and you can decide to do it another way :) * second one, if your IDE does white spaces this way, than create a big commit with only white space changes and than work from there. This is again not so important, but makes git blame and commits themselfs much less readable. Otherwise, yes, everything looks nice and clean, gg :)
lkavcic commented 2020-07-23 08:31:11 +00:00
Member
Copy Link

ok

ok
lexonomy manually merged commit a07b35c6a8 into master 2020-08-05 10:04:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
ozbolt
lkavcic
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lexonomy/lexonomy_custom_editor#2
No description provided.
Delete Branch "mt-homonymy-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?