Remove copying example on edit for stuff to work. Don't know what doesn't work

Reviewed-on: #6

.gitignore

@@ -10,5 +10,5 @@ build/*
 # using kdev4, works fairly nicely!
 .kdev4
 **/*.kdev4
-
+remote
 

res/main.less

@@ -156,16 +156,7 @@
             vertical-align: super;
             font-size: 0.7em;
           }
-          .translation-explanation:not(:empty) {
-            font-style: italic;
 
-            &:before {
-              content: '[';
-            }
-            &:after {
-              content: ']';
-            }
-          }
         }
 
         .translation-add {
@@ -175,6 +166,20 @@
       }
     }
 
+    .explanations:not(:empty) {
+      font-style: italic;
+
+      &:not(.solo) {
+        &:before {
+          content: '[';
+        }
+
+        &:after {
+          content: ']';
+        }
+      }
+    }
+
     .example {
       clear: left;
       margin-left: 1em;

src/export.py

@@ -5,8 +5,7 @@ from model.tags import export_tag
 def export_to_xml(model):
     xml_document = export_entry(model.entry)
     serializer = __new__(XMLSerializer())
-    return serializer.serializeToString(xml_document);
+    return serializer.serializeToString(xml_document)
-
 
 def export_entry(entry):
     parser = __new__(DOMParser())
@@ -14,156 +13,236 @@ def export_entry(entry):
     entry_xml = doc.firstChild
 
     # create head
-    head = doc.createElement("head")
+    head = entry.original_xml.querySelector("head")
-    entry_xml.appendChild(head)
+    if head is None:
+        head = doc.createElement("head")
+        entry.original_xml.appendChild(head)
+#     entry_xml.appendChild(head.cloneNode(True))
 
-    status = doc.createElement("status")
+    status = _original_xml_query_selector("head status", entry, doc)
     status.textContent = entry.status
-    head.appendChild(status)
+#     head.appendChild(status.cloneNode(True))
+
+
+
+#     headword = doc.createElement("headword")
+#     headword_lemma = doc.createElement("lemma")
+
+    headword = _original_xml_query_selector("head headword", entry, doc)
+    headword_lemma = _original_xml_query_selector("head headword lemma", entry, doc)
 
-    headword = doc.createElement("headword")
-    headword_lemma = doc.createElement("lemma")
     headword_lemma.textContent = entry.headword
     if entry.headword_type is not None:
         headword_lemma.setAttribute("type", entry.headword_type)
-    headword.appendChild(headword_lemma)
+    if entry.headword_audio is not None:
-    head.appendChild(headword)
+        headword_lemma.setAttribute("audio", entry.headword_audio)
 
-    homonymy = doc.createElement("homonymy")
+#     headword.appendChild(headword_lemma.cloneNode(True))
-    headword.appendChild(homonymy)
+#     head.appendChild(headword.cloneNode(True))
+    homonymy = _original_xml_query_selector("head headword homonymy", entry, doc)
+    original_homonymy = entry.original_xml.querySelectorAll("head headword homonymy homonymyFeature")
 
     for hFeature in entry.homonymy:
         feature = doc.createElement("homonymyFeature")
+        if hFeature.id >= 0:
+            feature = original_homonymy[hFeature.id]
+        else:
+            homonymy.appendChild(feature)
+
         feature.textContent = hFeature.value
-#       Can't use hFeature.name, because Python has name reserver and so it becomes py_name in JS
+#       Can't use hFeature.name, because Python has name reserved and so it becomes py_name in JS
         feature.setAttribute("name", hFeature["name"])
-        homonymy.appendChild(feature)
+
 
 
     # if({}) works uncorrectly in transcrypt
     if len(entry.lexical_unit) > 0:
-        lexunit = doc.createElement("lexicalUnit")
+        lexunit = _original_xml_query_selector("head lexicalUnit", entry, doc)
+#         lexunit = doc.createElement("lexicalUnit")
         lexunit.setAttribute("id", entry.lexical_unit["id"])
         lexunit.setAttribute("type", "single")
-        lexeme = doc.createElement("lexeme")
+        lexeme = _original_xml_query_selector("head lexicalUnit lexeme", entry, doc)
+#         lexeme = doc.createElement("lexeme")
         lexeme.setAttribute("lexical_unit_lexeme_id", entry.lexical_unit["id"])
         lexeme.textContent = entry.lexical_unit["text"]
 
-        lexunit.appendChild(lexeme)
+#         lexunit.appendChild(lexeme.cloneNode(True))
-        head.appendChild(lexunit)
+#         head.appendChild(lexunit.cloneNode(True))
 
-    grammar = doc.createElement("grammar")
+#   Example of keeping original xml and adding changes to it only
-    grammar_category = doc.createElement("category")
+    grammar = _original_xml_query_selector("head grammar", entry, doc)
+    grammar_category = _original_xml_query_selector("head grammar category", entry, doc)
     grammar_category.textContent = entry.grammar
-    grammar.appendChild(grammar_category)
+
-    head.appendChild(grammar)
+#     head.appendChild(grammar.cloneNode(True))
+    console.log(entry.original_xml)
 
     if len(entry.measure) > 0:
-        measure_list = doc.createElement("measureList")
+        measure_list = _original_xml_query_selector("head measureList", entry, doc)
-        measure = doc.createElement("measure")
+        measure = _original_xml_query_selector("head measureList measure", entry, doc)
+
+#         measure_list = doc.createElement("measureList")
+#         measure = doc.createElement("measure")
         measure.setAttribute("source", entry.measure["source"])
         measure.setAttribute("type", entry.measure["type"])
         measure.textContent = entry.measure["text"]
 
-        measure_list.appendChild(measure)
+#         head.appendChild(measure_list)
-        head.appendChild(measure_list)
-
-    variants = doc.createElement("variantList")
-    head.appendChild(variants)
 
+#     Same problem as homonymy
+    variants = _original_xml_query_selector("head variantList", entry, doc)
+    og_variants = entry.original_xml.querySelectorAll("head variantList variant")
     for v in entry.variants:
         variant = doc.createElement("variant")
-        variant.textContent = v
+        if v.id >= 0:
-        variants.appendChild(variant)
+            variant = og_variants[v.id]
+        else:
+            variants.appendChild(variant)
 
-    relist = doc.createElement("relatedEntryList")
+        variant.textContent = v.value
-    head.appendChild(relist)
 
+#     relist = _original_xml_query_selector("head relatedEntryList", entry, doc)
+#     relist = doc.createElement("relatedEntryList")
+    relist = _original_xml_query_selector("head relatedEntryList", entry, doc)
+    og_relist = entry.original_xml.querySelectorAll("head relatedEntryList relatedEntry")
+#     head.appendChild(relist.cloneNode(True))
     for re in entry.related_entries:
         relateEntry = doc.createElement("relatedEntry")
-        relateEntry.textContent = re
-        relist.appendChild(relateEntry)
 
-    head.appendChild(_export_label_list(doc, entry.labels))
+        if re.id >= 0:
+            relateEntry = og_relist[re.id]
+        else:
+            relist.appendChild(relateEntry)
 
-    comment = doc.createElement("comment")
+        relateEntry.textContent = re.value
+    _export_label_list(doc, entry.labels, head)
+
+#     comment = doc.createElement("comment")
+    comment = _original_xml_query_selector("head comment", entry, doc)
     comment.textContent = entry.comment
-    head.appendChild(comment)
+#     head.appendChild(comment.cloneNode(True))
 
     # now lets do body
-    body = doc.createElement("body")
-    entry_xml.appendChild(body)
 
-    sense_list = doc.createElement("senseList")
+    body = entry.original_xml.querySelector("body")
-    body.appendChild(sense_list)
+    if body is None:
+        body = doc.createElement("body")
+        entry.original_xml.appendChild(body)
+#     entry_xml.appendChild(body)
 
+#     sense_list = doc.createElement("senseList")
+    sense_list = _original_xml_query_selector("body senseList", entry, doc)
     for sense in entry.senses:
-        sense_list.appendChild(export_sense(doc, sense))
+        sense_xml = doc.createElement("sense")
 
-    return doc
+        if sense.original_xml is not None:
+            sense_xml = sense.original_xml
+
+        sense_list.appendChild(sense_xml)
+        export_sense(doc, sense, sense_xml)
+
+    return entry.original_xml
 
 
-def export_sense(doc, sense):
+def export_sense(doc, sense, sense_xml):
-    sense_xml = doc.createElement("sense")
+    _export_label_list(doc, sense.labels, sense_xml)
-    sense_xml.appendChild(_export_label_list(doc, sense.labels))
 
-    definition_list = doc.createElement("definitionList")
+    definition_list = sense_xml.querySelector("definitionList")
-    sense_xml.appendChild(definition_list)
+    if definition_list is None:
+        definition_list = doc.createElement("definitionList")
+        sense_xml.appendChild(definition_list)
 
-    for typ, text in sense.definition.items():
+    for definition in sense.definitions:
-        definition = doc.createElement("definition")
+        definition_xml = definition.original_xml if definition.original_xml != None else doc.createElement("definition")
-        definition.textContent = text
+        definition_list.appendChild(definition_xml)
-        definition.setAttribute("type", typ)
+        definition_xml.textContent = definition.value
-        definition_list.appendChild(definition)
+        definition_xml.setAttribute("type", definition.type)
 
-    translation_container_list = doc.createElement("translationContainerList")
+    translation_container_list = sense_xml.querySelector("sense > translationContainerList")
+    if translation_container_list is None:
+        translation_container_list = doc.createElement("translationContainerList")
+        sense_xml.appendChild(translation_container_list)
     export_translation_list(doc, sense, translation_container_list)
-    sense_xml.appendChild(translation_container_list)
 
-    example_container_list = doc.createElement("exampleContainerList")
+    example_container_list = sense_xml.querySelector("sense > exampleContainerList")
-    sense_xml.appendChild(example_container_list)
+    if example_container_list is None:
+        example_container_list = doc.createElement("exampleContainerList")
+        sense_xml.appendChild(example_container_list)
 
     for example in sense.examples:
-        example_container = example.export(doc)
+        example_container = example.export(doc, example_container_list)
-        export_translation_list(doc, example, example_container)
+
-        example_container_list.appendChild(example_container)
+        translation_container_list = example_container.querySelector("exampleContainer > translationContainerList")
+        if translation_container_list is None:
+            translation_container_list = doc.createElement("translationContainerList")
+            example_container.appendChild(translation_container_list)
+
+        export_translation_list(doc, example, translation_container_list)
 
-    return sense_xml
 
 def export_translation_list(doc, py_parent, xml_parent):
     for cidx, cluster in enumerate(py_parent.translations):
         for translation in cluster:
-            translation_container = export_translation(doc, translation)
+            translation_container = export_translation(doc, translation, xml_parent)
             translation_container.setAttribute("cluster", str(cidx + 1))
-            xml_parent.appendChild(translation_container)
+#             xml_parent.appendChild(translation_container)
 
 
-def export_translation(doc, translation):
+def export_translation(doc, translation, xml_parent):
-    translation_xml = doc.createElement("translationContainer")
+    translation_xml = translation.original_xml if translation.original_xml != None else doc.createElement("translationContainer")
-    translation_xml.appendChild(_export_label_list(doc, translation.tags))
+    xml_parent.appendChild(translation_xml)
+    _export_label_list(doc, translation.tags, translation_xml)
+
+    console.log(translation)
+    actual_t = translation.original_xml.querySelector("translation") if translation.original_xml != None else doc.createElement("translation")
+    if translation.original_xml is None:
+        translation_xml.appendChild(actual_t)
 
-    actual_t = doc.createElement("translation")
     actual_t.textContent = translation.translation
     actual_t.setAttribute("targetLang", translation.targetLang)
 
+    if translation.audio:
+        actual_t.setAttribute("audio", translation.audio)
+
     if translation.source:
         actual_t.setAttribute("source", translation.source)
-    translation_xml.appendChild(actual_t)
 
-    explanation = doc.createElement("explanation")
+    if len(translation.explanationList) > 0 :
-    explanation.textContent = translation.explanation
+        _export_explanation_list(doc, translation.explanationList, translation_xml)
-    translation_xml.appendChild(explanation)
 
     return translation_xml
 
+def _export_explanation_list(doc, lst, xml_parent):
+    result = xml_parent.querySelector("explanationList")
+    if result is None:
+        result = doc.createElement("explanationList")
+        xml_parent.appendChild(result)
+
+    for explanation in lst:
+        result.appendChild(explanation.export(doc))
+
+def _export_label_list(doc, lst, xml_parent):
+    result = xml_parent.querySelector("labelList")
+    if result is None:
+        result = doc.createElement("labelList")
+        xml_parent.appendChild(result)
+
+    for key, value, idx in lst:
 
-def _export_label_list(doc, lst):
-    result = doc.createElement("labelList")
-    for key, value in lst:
         key, value = export_tag(key, value)
-
         label_el = doc.createElement("label")
+        if idx >= 0:
+            label_el = result.querySelectorAll("label")[idx]
+        else:
+            result.appendChild(label_el)
+
         label_el.textContent = value
         label_el.setAttribute('type', key)
-        result.appendChild(label_el)
     return result
+
+def _original_xml_query_selector(selector, entry, doc, parent_selector = selector.rsplit(' ', 1)[0]):
+    query = entry.original_xml.querySelector(selector)
+    if query is None:
+        query = doc.createElement(selector.rsplit(' ', 1)[1])
+        entry.original_xml.querySelector(parent_selector).appendChild(query)
+    return query

src/lib/structure_conversions.py

@@ -34,12 +34,23 @@ def build_structure_conversions():
         structure_conversions.append((__new__(RegExp(vfrom, 'u')), vto_name, vto_id))
         
         
-def convert_structure(structure):
+def convert_structure(structure, type):
     if structure_conversions is None:
         build_structure_conversions()
     
     for vfrom, vto_name, vto_id in structure_conversions:
         match = structure.match(vfrom)
+        # fix for ids 65, 66, 67 which instead matched with 64
+        if match and vto_id == '64' and '-s' in type:
+            vto_name = 's0-vp-s0'
+            vto_id = '65'
+        elif match and vto_id == '64' and '-g' in type:
+            vto_name = 'gg-vp-gg'
+            vto_id = '66'
+        elif match and vto_id == '64' and '-r' in type:
+            vto_name = 'r-vp-r'
+            vto_id = '67'
+
         if match:
             # we need to remove replace alias here as we want to use javascript's one
             __pragma__('noalias', 'replace')
@@ -49,4 +60,4 @@ def convert_structure(structure):
             return result, vto_id
     
     window.console.log("Unknown structure: ", structure)
-    return None
+    return 'N/A', '/'

src/message/common_accessors.py

@@ -4,22 +4,30 @@ from browser import document
 def generic_list_getter():
     result = []
     for input_el in document.getElementsByClassName("list-adder-input"):
-        result_candidate = input_el.value
+        result_candidate = {"value": input_el.value}
-        if result_candidate != "":
+        if input_el.hasAttribute("data-id"):
+            result_candidate.id = int(input_el.getAttribute("data-id"))
+        if result_candidate.value != "":
             result.append(result_candidate)
     return result
 
 # Formats data from inputs to name-value objects
-def homonymy_list_getter():
+def double_list_getter(firstParameter, secondParameter, allowEmptyField = False):
     result = []
-    for row in document.getElementsByClassName("label-list-row"):
+    for row in document.getElementsByClassName("double-list-row"):
-        value = row.querySelector(".value-input").value
+        output = {}
-        name = row.querySelector(".name-input").value
+        output[firstParameter] = row.querySelector("." + firstParameter + "-input").value
+        output[secondParameter] = row.querySelector("." + secondParameter + "-input").value
+        if row.hasAttribute("data-id"):
+            output.id = int(row.getAttribute("data-id"))
 
-        if ("" in [name, value]):
+        if (allowEmptyField is False and '' in [output[firstParameter], output[secondParameter]]):
             continue
 
-        result.append({"name": name, "value": value})
+        if (allowEmptyField is True and all('' == value or value.isspace() for value in [output[firstParameter], output[secondParameter]])):
+            continue
+
+        result.append(output)
 
     return result
 
@@ -30,6 +38,7 @@ def label_list_getter():
         ltype = row.querySelector(".label-type")
         lvalue = row.querySelector(".label-value")
         lother = row.querySelector(".label-value-other")
+        idx = int(row.getAttribute("data-id")) if row.hasAttribute("data-id") else -1
 
         if lother is None:
             continue
@@ -41,7 +50,7 @@ def label_list_getter():
         if not value:
             continue
 
-        result.append((ltype.textContent, value))
+        result.append((ltype.textContent, value, idx))
 
     kontrastivno = document.getElementById("kontrastivno-input").checked;
     if kontrastivno:

src/message/delete_messages.py

@@ -21,7 +21,9 @@ class DeleteRelatedEntries(DeleteVariants):
 
 class DeleteHomonymy(NoReset):
     def update_model(self, model):
-        for el in document.getElementsByClassName("list-adder-input"):
+        for el in document.getElementsByClassName("name-input"):
+            el.value = ""
+        for el in document.getElementsByClassName("value-input"):
             el.value = ""
 
 

src/message/example_edit.py

@@ -60,7 +60,7 @@ class EditExampleText(Message):
         if example.newly_created:
             example.newly_created = False
             sense.examples.append(example)
-        
+        console.log(example)
         idx = 0
         for txt in document.getElementsByClassName("example-component-text"):
             example.components[idx].text = txt.value

src/message/sense_edit.py

@@ -18,10 +18,15 @@ class SenseMoveUp(DataChgClickMessage):
         assert(sidx >= 0)
         if sidx == 0:
             return
+#         if sense.original_idx >= 0:
+#             if model.entry.senses[sidx - 1].original_idx >= 0:
+#                 original_parent = model.entry.original_xml.querySelector("body senseList")
+#                 original_parent.insertBefore(original_parent.children[sidx], original_parent.children[sidx - 1])
+#                 model.entry.senses[sidx].original_idx, model.entry.senses[sidx - 1].original_idx = model.entry.senses[sidx - 1].original_idx, model.entry.senses[sidx].original_idx
+#             else:
 
         model.entry.senses[sidx], model.entry.senses[sidx - 1] = model.entry.senses[sidx - 1], model.entry.senses[sidx]
 
-
 class SenseMoveDown(DataChgClickMessage):
     def update_model(self, model):
         sense = self.get_arg(0, Sense)
@@ -30,7 +35,10 @@ class SenseMoveDown(DataChgClickMessage):
         assert(sidx >= 0)
         if sidx == len(model.senses) - 1:
             return
-        
+#         if sense.original_idx >= 0 and model.entry.senses[sidx + 1].original_idx >= 0:
+#             original_parent = model.entry.original_xml.querySelector("body senseList")
+#             original_parent.insertBefore(original_parent.children[sidx + 1], original_parent.children[sidx])
+#             model.entry.senses[sidx].original_idx, model.entry.senses[sidx + 1].original_idx = model.entry.senses[sidx + 1].original_idx, model.entry.senses[sidx].original_idx
         model.entry.senses[sidx], model.entry.senses[sidx + 1] = model.entry.senses[sidx + 1], model.entry.senses[sidx]
 
 
@@ -42,6 +50,12 @@ class SenseBin(DataChgClickMessage):
         assert(sidx >= 0)
         model.entry.senses.splice(sidx, 1)
 
+#         if sense.original_idx >= 0:
+#             model.entry.original_xml.querySelectorAll("body senseList sense")[sense.original_idx].remove()
+#             for index, sense in enumerate(model.entry.senses):
+#                 if (sense.original_idx >= 0):
+#                     sense.original_idx = index
+
 
 class AddMultiwordExample(DataChgClickMessage):
     def on_event(self, event):

src/message/simple_edits.py

@@ -17,6 +17,14 @@ class EditSenseLabel(Message):
         sense = self.get_arg(0, Sense)
         sense.labels = common_accessors.label_list_getter()
 
+        keptIds = [entry[2] for entry in sense.labels]
+        for index, entry in enumerate(sense.original_xml.querySelectorAll("labelList label")):
+                    if (index not in keptIds):
+                        entry.remove()
+
+        for index, entry in enumerate(sense.labels):
+                    if (entry[2] >= 0):
+                        entry[2] = index
 
 class AddToGenericList(NoReset):
     def update_model(self, model):
@@ -43,14 +51,14 @@ class AddToLabelList(NoReset):
 class AddSense(Message):
     def update_model(self, model):
         sense = Sense()
-        sense.definition = {"indicator": "New Sense"}
+        sense.definitions.append({"type": "indicator", "value": "New Sense"})
         model.entry.senses.append(sense)
 
 
 class EditSenseDefinition(QuestionMessage):
     def update_model(self, model):
         sense = self.get_arg(0, Sense)
-        sense.definition["indicator"] = self.new_text
+        sense.definitions[0].value = self.new_text
 
 
 class EditComment(QuestionMessage):
@@ -86,23 +94,36 @@ class DoChosenExamples(Message):
 class EditVariants(Message):
     def update_model(self, model):
         variants = common_accessors.generic_list_getter()
+        update_entries(variants, "head variantList variant", model)
         model.entry.variants = variants
 
 class EditHomonymy(Message):
     def update_model(self, model):
-        homonymy = common_accessors.homonymy_list_getter()
+        homonymy = common_accessors.double_list_getter("value", "name")
+
+        update_entries(homonymy, "head headword homonymy homonymyFeature", model)
+
         model.entry.homonymy = homonymy
 
 
 class EditRelatedEntries(Message):
     def update_model(self, model):
         related_entries = common_accessors.generic_list_getter()
+        update_entries(related_entries, "head relatedEntryList relatedEntry", model)
         model.entry.related_entries = related_entries
 
 
 class EditEntryLabels(Message):
     def update_model(self, model):
         labels = common_accessors.label_list_getter()
+        keptIds = [entry[2] for entry in labels]
+        for index, entry in enumerate(model.entry.original_xml.querySelectorAll("labelList label")):
+                    if (index not in keptIds):
+                        entry.remove()
+
+        for index, entry in enumerate(labels):
+                    if (entry[2] >= 0):
+                        entry[2] = index
         model.entry.labels = labels
 
 
@@ -118,3 +139,13 @@ class ExampleClusterAdd(DataChgClickMessage):
         example = self.get_arg(0, Example)
         example.set_cluster(ExampleClusters.first_empty_cluster())
 
+
+def update_entries(updated_list, query, model):
+    keptIds = [entry.id for entry in updated_list]
+    for index, entry in enumerate(model.entry.original_xml.querySelectorAll(query)):
+                if (index not in keptIds):
+                    entry.remove()
+
+    for index, entry in enumerate(updated_list):
+                if (entry.id >= 0):
+                    entry.id = index

src/message/ske_messages.py

@@ -26,6 +26,7 @@ class SkeExample:
         self.mid = ""
         self.s_id = ""
         self.gf2_good = None
+        self.gf2_check = False
     
     @staticmethod
     def fromLine(line):
@@ -58,15 +59,7 @@ class SkeCollocation:
     def __init__(self, data):
         self.word = data.word
         self.frequency = data.count
-        
+        self.structure_name, self.structure_id = convert_structure(data.gramrel, data.lempos)
-        info = convert_structure(data.gramrel)
-        if info is None:
-            self.structure_name = None
-            self.structure_id = None
-        else:
-            self.structure_name = info[0]
-            self.structure_id = info[1]
-            
         
         self.other = {"score": data.score, "cm": data.cm}
 
@@ -148,7 +141,7 @@ class SkeModal(ClickMessage):
         elif type(data) is list:
             window.console.log(data)
             # check if gf2 examples are loaded or not
-            if data[0].gf2_good is None:
+            if not data[0].gf2_check and type(data[0]) is SkeExample:
                 # we get the data, we have to match it with available data on our gf2 examples API
                 match_gf2_examples(data, page_num, search_term, ske_index)
  
@@ -169,12 +162,18 @@ class SkeModalGf2Update(SkeModal):
             example.gf_good = False
             data_dict[example.s_id] = example
             
+        bad_response = dict(response_data["bad"])
+        for gf_sid, gf_data in bad_response.items():
+            data_dict[gf_sid].gf2_good = None
+            data_dict[gf_sid].gf2_check = True
+
         good_response = dict(response_data["good"])
         for gf_sid, gf_data in good_response.items():
             data_dict[gf_sid].left = gf_data.left
             data_dict[gf_sid].mid = gf_data.mid
             data_dict[gf_sid].right = gf_data.right
             data_dict[gf_sid].gf2_good = True
+            data_dict[gf_sid].gf2_check = True
         
         # changed data_dict, now we can redraw!
         # just let it do its thing in update_model
@@ -225,6 +224,8 @@ class SkeInsert(DataChgClickMessage):
                 console.log("You really should not be here, my lady")
                 continue
         
+        model.reset()
+    
     def _as_corpus_example(self, example):
         new_example = Example()
         new_example.inner = CorpusExample()

src/message/translation_edit.py

@@ -4,6 +4,7 @@ import message.common_accessors as common_accessors
 from browser import document, window
 from model.translation import Translation
 from model.sense import Sense
+from model.explanation import Explanation
 
 
 
@@ -13,11 +14,27 @@ class EditTranslation(DataChgClickMessage):
         self.old_cluster_idx = self.get_arg(1, int)
 
         self.translation.translation = document.getElementById("etv").value
-        self.translation.explanation = document.getElementById("ete").value
+
+#         This could be dangerous if double_list_getter is getting data from any other list as well.
+        explanations = common_accessors.double_list_getter('value', 'language', True)
+        self.translation.explanationList = []
+        for entry in explanations:
+            explanation = Explanation()
+            explanation.value = entry.value
+            explanation.language = entry.language
+            explanation.original_xml = entry.original_xml if entry.original_xml != None else None
+            self.translation.explanationList.append(explanation)
 
         # common_accessors.label_list_getter()
         self.translation.tags = common_accessors.label_list_getter()
+        keptIds = [entry[2] for entry in self.translation.tags]
+        for index, entry in enumerate(self.translation.original_xml.querySelectorAll("labelList label")):
+                    if (index not in keptIds):
+                        entry.remove()
 
+        for index, entry in enumerate(self.translation.tags):
+                    if (entry[2] >= 0):
+                        entry[2] = index
         # check if empty, remove!
         if self.translation.is_empty():
             model.entry.remove_translation(self.translation)

src/model/__init__.py

@@ -2,3 +2,4 @@ from model.model import Model
 from model.sense import Sense
 from model.translation import Translation
 from model.example import Example
+from model.explanation import Explanation

src/model/data.py

@@ -63,7 +63,7 @@ class Data:
             return None
     
     def overwrite_with_copy(self):
-        for key, value in dict(self._copy).items():
+        for key, value in dict(self).items():
             # skip functions and _copy
             if key == "_copy" or type(value) is None:
                 continue

src/model/entry.py

@@ -14,6 +14,7 @@ class Entry(Data):
         self.headword = ""
         self.homonymy = []
         self.headword_type = None
+        self.headword_audio = None
         self.grammar = ""
         self.comment = ""
         self.variants = []
@@ -22,21 +23,26 @@ class Entry(Data):
         self.measure = {}
         self.labels = []
         self.senses = []
+        self.original_xml = None
 
     def import_xml(self, entry_xml):
+        console.log(entry_xml)
+        self.original_xml = entry_xml
         status = entry_xml.querySelector("head status")
+
         headword = entry_xml.querySelector("head headword lemma")
 
         grammar = entry_xml.querySelector("head grammar category")
         comment = entry_xml.querySelector("head comment")
         self.status = status.textContent if status else ""
         self.headword = headword.textContent if headword else ""
-        self.headword_type = headword.getAttribute("type") if headword else None
+        self.headword_type = headword.getAttribute("type") if headword and headword.hasAttribute("type") else None
+        self.headword_audio = headword.getAttribute("audio") if headword and headword.hasAttribute("audio") else None
         self.grammar = grammar.textContent if grammar else ""
         self.comment = comment.textContent if comment else ""
-        self.variants = [v.textContent for v in entry_xml.querySelectorAll("head variantList variant")]
+        self.variants = [{"value": v.textContent, "id": index} for index, v in enumerate(entry_xml.querySelectorAll("head variantList variant"))]
-        self.homonymy = [{"value": v.textContent, "name": v.getAttribute("name")} for v in entry_xml.querySelectorAll("head headword homonymy homonymyFeature ")]
+        self.homonymy = [{"value": v.textContent, "name": v.getAttribute("name"), "id": index} for index, v in enumerate(entry_xml.querySelectorAll("head headword homonymy homonymyFeature "))]
-        self.related_entries = [re.textContent for re in entry_xml.querySelectorAll("head relatedEntryList relatedEntry")]
+        self.related_entries = [{"value": re.textContent, "id": index} for index, re in enumerate(entry_xml.querySelectorAll("head relatedEntryList relatedEntry"))]
 
         lex_unit = entry_xml.querySelector("lexical_unit lexeme,lexicalUnit lexeme")
         if lex_unit:
@@ -49,12 +55,13 @@ class Entry(Data):
             self.measure["type"] = measure.getAttribute("type")
             self.measure["text"] = measure.textContent
 
-        self.labels = import_label_list("head labelList label", entry_xml)
+        self.labels = import_label_list("head labelList label", self.original_xml)
 
         for i, sense_xml in enumerate(entry_xml.querySelectorAll("body senseList sense")):
             sense = Sense()
             sense.import_xml(sense_xml, i)
             self.senses.append(sense)
+            sense_xml.remove()
 
 
     def view(self, model):
@@ -91,7 +98,7 @@ class Entry(Data):
         if len(self.variants) == 0:
             view_buttons.append(buttons[0])
         else:
-            view_table.append((buttons[0], ", ".join(self.variants)))
+            view_table.append((buttons[0], ", ".join(v.value for v in self.variants)))
 
         if len(self.homonymy) == 0:
             view_buttons.append(buttons[4])
@@ -101,7 +108,7 @@ class Entry(Data):
         if len(self.related_entries) == 0:
             view_buttons.append(buttons[1])
         else:
-            view_table.append((buttons[1], ", ".join(self.related_entries)))
+            view_table.append((buttons[1], ", ".join(re.value for re in self.related_entries)))
 
         if len(self.labels) == 0:
             view_buttons.append(buttons[2])
@@ -136,4 +143,3 @@ class Entry(Data):
                     if translation in cluster:
                         cluster.remove(translation)
                         return
-

src/model/example/component_lexeme.py

@@ -11,21 +11,23 @@ class ComponentLexeme(Data):
         self.text = ""
         self.role = ""
         self.no_space = False
+        self.original_xml = None
 
     def import_xml(self, xml):
+        self.original_xml = xml.cloneNode(True)
         if xml.nodeName == "#text":
             self.text = xml.data
             self.role = None
         else:
             self.text = xml.textContent
             self.role = xml.getAttribute("role")
-            
             if xml.hasAttribute("space"):
                 self.no_space = xml.getAttribute("space") == "false"
 
-            for oth_attr in ["lexical_unit_lexeme_id", "slolex", "kol"]:
+            for oth_attr in ["lexeme_id", "lexical_unit_lexeme_id", "slolex", "kol", "sloleks"]:
                 if xml.hasAttribute(oth_attr):
                     self.other_attributes[oth_attr] = xml.getAttribute(oth_attr)
+        xml.remove()
 
     def isValid(self):
         return len(self.text) > 0
@@ -33,8 +35,8 @@ class ComponentLexeme(Data):
     def export(self, doc):
         if self.role is None:
             return doc.createTextNode(self.text)
+        result = self.original_xml if self.original_xml is not None else doc.createElement("comp")
 
-        result = doc.createElement("comp")
         result.setAttribute("role", self.role)
         result.textContent = self.text
 

src/model/example/corpus_example.py

@@ -3,14 +3,17 @@ from lib.snabbdom import h
 class CorpusExample:
     def __init__(self):
         self.other_attributes = {}
+        self.original_xml = None
     
     def import_xml(self, example_xml):
         for oth_attr in ["example_id", "modified", "lexical_unit_id", "audio"]:
             if example_xml.hasAttribute(oth_attr):
                 self.other_attributes[oth_attr] = example_xml.getAttribute(oth_attr)
+        self.original_xml = example_xml
+        example_xml.remove()
 
     def export(self, doc, modified):
-        result = doc.createElement("corpusExample")
+        result = self.original_xml if self.original_xml is not None else doc.createElement("corpusExample")
         if modified:
             result.setAttribute("modified", "true")
             

src/model/example/example.py

@@ -13,6 +13,7 @@ from model.example_clusters import ExampleClusters
 
 class Example(Data):
     def __init__(self):
+        self.original_xml = None
         self.translations = []
         self.inner = None
         self.components = []
@@ -40,21 +41,21 @@ class Example(Data):
         return example
 
     def import_xml(self, example_xml):
-        self.translations = from_container_list(example_xml.querySelectorAll("translationContainer"))
+        self.translations = from_container_list(example_xml.querySelectorAll("translationContainerList translationContainer"))
-        
+        self.original_xml = example_xml.cloneNode(True)
         if example_xml.hasAttribute("modified"):
             self.edited = example_xml.getAttribute("modified") == "true"
 
-        inner_xml = example_xml.querySelector("corpusExample")
+        inner_xml = self.original_xml.querySelector("corpusExample")
         if inner_xml is not None:
             self.inner = CorpusExample()
         else:
-            inner_xml = example_xml.querySelector("multiwordExample") 
+            inner_xml = self.original_xml.querySelector("multiwordExample")
             self.inner = MultiwordExample()
 
         self.inner.import_xml(inner_xml)
 
-        for idx, comp_xml in enumerate(inner_xml.childNodes):
+        for idx, comp_xml in enumerate(self.inner.original_xml.childNodes):
             comp = ComponentLexeme()
             comp.import_xml(comp_xml)
             if comp.isValid():
@@ -62,11 +63,10 @@ class Example(Data):
 
         self.check_multiword_components()
 
-    def export(self, doc):
+    def export(self, doc, xml_parent):
         self.check_multiword_components()
-        
+        result = self.original_xml if self.original_xml != None else doc.createElement("exampleContainer")
-        result = doc.createElement("exampleContainer")
+        xml_parent.appendChild(result)
-        
         inner = self.inner.export(doc, self.edited)
         # TODO: bad quick fix
         for comp in self.components:

src/model/example/multiword_example.py

@@ -6,8 +6,10 @@ class MultiwordExample:
         self.other_attributes = {}
         self.cluster = -1
         self.type = None
+        self.original_xml = None
     
     def import_xml(self, example_xml):
+        self.original_xml = example_xml.cloneNode(True)
         for oth_attr in ["lexical_unit_id", "structure_id", "structureName", "audio", "frequency", "logDice"]:
             if example_xml.hasAttribute(oth_attr):
                 self.other_attributes[oth_attr] = example_xml.getAttribute(oth_attr)
@@ -17,6 +19,9 @@ class MultiwordExample:
         if example_xml.hasAttribute("type"):
             self.type = example_xml.getAttribute("type")
 
+
+        example_xml.remove()
+
     @staticmethod
     def _determine_cluster_number(example_xml):
         if not example_xml.hasAttribute("cluster"):
@@ -27,8 +32,8 @@ class MultiwordExample:
             return cluster
             
     def export(self, doc, _modified):
-        result = doc.createElement("multiwordExample")
+        result = self.original_xml if self.original_xml is not None else doc.createElement("multiwordExample")
-            
+        # result = doc.createElement("multiwordExample")
         for key, value in self.other_attributes.items():
             result.setAttribute(key, value)
         

src/model/explanation.py

@@ -0,0 +1,22 @@
+from model.data import Data
+
+from lib.snabbdom import h
+
+
+class Explanation(Data):
+    def __init__(self):
+        self.value = ""
+        self.language = ""
+        self.original_xml = None
+
+    def import_dom(self, explanation_xml):
+        self.original_xml = explanation_xml.cloneNode(True)
+        self.value = explanation_xml.textContent if explanation_xml else ""
+        self.language = explanation_xml.getAttribute("language") if explanation_xml.hasAttribute("language") else ""
+
+    def export(self, doc):
+        result = self.original_xml if self.original_xml != None else doc.createElement("explanation")
+        result.textContent = self.value
+        if self.language != "": result.setAttribute('language', self.language)
+
+        return result

src/model/sense.py

@@ -11,25 +11,34 @@ from view.utils import clean_label
 class Sense(Data):
     def __init__(self):
         self.original_idx = -1
-        self.definition = {}
+        self.original_xml = None
+        self.definitions = []
         self.labels = []
         self.translations = []
         self.examples = []
 
     def import_xml(self, sense_xml, idx):
         self.original_idx = idx
-        for definition in sense_xml.querySelectorAll("definitionList definition"):
+        self.original_xml = sense_xml.cloneNode(True)
-            key = definition.getAttribute("type")
-            self.definition[key] = definition.textContent
 
-        self.labels = import_label_list("sense > labelList label", sense_xml)
+        for definition in self.original_xml.querySelectorAll("definitionList definition"):
+            definition_object = {}
+            definition_object.type = definition.getAttribute("type")
+            definition_object.value = definition.textContent
+            definition_object.original_xml = definition
+            definition.remove()
+            self.definitions.append(definition_object)
+
+        self.labels = import_label_list("sense > labelList label", self.original_xml)
         self.translations = from_container_list(
-            sense_xml.querySelectorAll("translationContainerList translationContainer"))
+            self.original_xml.querySelectorAll('sense > translationContainerList translationContainer'))
-        
+        for example_xml in self.original_xml.querySelectorAll("exampleContainerList exampleContainer"):
-        for example_xml in sense_xml.querySelectorAll("exampleContainerList exampleContainer"):
             example = Example()
             example.import_xml(example_xml)
             self.examples.append(example)
+            example_xml.remove()
+
+        console.log(self.original_xml)
 
 
     def merge_labels(self):
@@ -44,7 +53,7 @@ class Sense(Data):
           h("div.sense", {}, [
             h("span.sense-label-list", { "on": { "click": M.msg(M.ShowSenseLabelEdit, self) }}, [
                 h("span.sense-label", {}, clean_label(slabel)) for _, slabel in self.labels ]),
-            h("span.sense-definition", { "on": { "click": M.msg(M.ShowSenseDefinitionEdit, self) }}, self.definition["indicator"]),
+            h("span.sense-definition", { "on": { "click": M.msg(M.ShowSenseDefinitionEdit, self) }}, ", ".join(d.value for d in self.definitions)),
             h("div", {}, View.view_translations(self.translations, self, model)),
             h("div", {}, examples)])])
         return result

src/model/tags.py

@@ -35,12 +35,12 @@ STYLE_SECTIONS = [("registrske", "register"),
 
 def import_label_list(selector, xml_element):
     result = []
-    for tag_xml in xml_element.querySelectorAll(selector):
+    for index, tag_xml in enumerate(xml_element.querySelectorAll(selector)):
         t_type = tag_xml.getAttribute("type")
         t_value = tag_xml.textContent
 
         t_type, t_value = import_tag(t_type, t_value)
-        result.append((t_type, t_value))
+        result.append((t_type, t_value, index))
     return result
 
 

src/model/translation.py

@@ -1,4 +1,5 @@
 from model.tags import import_label_list
+from model.explanation import Explanation
 from model.data import Data
 
 from lib.snabbdom import h
@@ -19,6 +20,8 @@ def from_container_list(translation_list_container_xml):
         t = Translation()
         t.import_xml(translation_xml)
         translations.append((num_cluster, t))
+        translation_xml.remove()
+
 
     result = [[] for _ in range(max_num_cluster)]
     for clusterNum, translation in translations:
@@ -29,24 +32,31 @@ def from_container_list(translation_list_container_xml):
 
 class Translation(Data):
     def __init__(self, translation_xml):
+        self.original_xml = None
         self.translation = ""
         self.source = ""
         self.targetLang = ""
-        self.explanation = ""
+        self.audio = ""
+        self.explanationList = set()
         self.tags = []
 
     def import_xml(self, translation_xml):
         translation = translation_xml.querySelector("translation")
+        self.original_xml = translation_xml.cloneNode(True)
 
         if translation:
             self.translation = translation.textContent
             self.source = translation.getAttribute("source") if translation.hasAttribute("source") else ""
             self.targetLang = translation.getAttribute("targetLang")  if translation.hasAttribute("targetLang") else ""
+            self.audio = translation.getAttribute("audio")  if translation.hasAttribute("audio") else ""
 
-        explanation = translation_xml.querySelector("explanation")
+        explanationList = self.original_xml.querySelectorAll("explanationList explanation")
-        self.explanation = explanation.textContent if explanation else ""
+        for explanation_dom in explanationList:
-        self.tags = import_label_list("labelList label", translation_xml)
+            explanation = Explanation()
-    
+            explanation.import_dom(explanation_dom)
+            self.explanationList.append(explanation)
+            explanation_dom.remove()
+        self.tags = import_label_list("labelList label", self.original_xml)
 
     def view(self, model):
         elements = []
@@ -61,8 +71,10 @@ class Translation(Data):
         if self.source:
             elements.append(h("span.translation-source", {}, self.source))
 
-        explanation_class = ".translation-explanation" if self.translation else ""
+        if (self.explanationList):
-        elements.append(h("span{}".format(explanation_class), {}, self.explanation))
+            explanation_class = ".explanations" if self.translation else ".explanations.solo"
+            explanations = [explanation.value for explanation in self.explanationList]
+            elements.append(h("span{}".format(explanation_class), {}, ", ".join(explanations)))
 
         return h("div.translation-div", {"on": {"click": M.msg(M.ShowTranslationMenu, self) }}, elements)
 
@@ -73,6 +85,6 @@ class Translation(Data):
         # next two are not checked as the also can not be deleted via gui
         # result = result and self.source == ""
         # result = result and self.targetLang == ""
-        result = result and self.explanation == ""
+        result = result and len(self.explanationList) == 0
         result = result and len(self.tags) == 0
         return result

src/view/modal_templates.py

@@ -42,15 +42,19 @@ def question(question, current_value):
 def generic_list_editor(title, element_list_getter):
     content = [h("p", {}, title)]
     for slabel in element_list_getter():
+        idAttr = {"data-id": slabel.id} if slabel.id >= 0 else {}
         content.append(h("label", {}, [
-            h("input.list-adder-input", {"props": {"type": "text", "value": slabel}}, "")]))
+            h("input.list-adder-input", {"props": {"type": "text", "value": slabel.value or slabel}, "attrs": idAttr}, "")]))
+
+        console.log(content)
     content.append(h("button", {"on": {"click": message.msg(message.AddToGenericList, element_list_getter)}}, "+"))
     return content
 
 def homonymy_editor(title, current_labels):
-    def split_line2(left, right):
+    def split_line2(left, right, labelId):
-        cls = "flex.two{}".format(".label-list-row")
+        cls = "flex.two{}".format(".double-list-row")
-        return h("div.{}".format(cls), {}, [
+        isId = {"attrs": {"data-id": labelId}} if labelId >= 0 else {}
+        return h("div.{}".format(cls), isId, [
             h("div.half", {}, left), h("div.half", {}, right)])
 
     content = [h("p", {}, title)]
@@ -58,22 +62,46 @@ def homonymy_editor(title, current_labels):
         name = []
         value = []
         name.append(h("label", {"attrs": {"for": i}}, "Name:"))
-        name.append(h("input.name-input", {"props": {"type": "text", "value": feature["name"], "id": i}}, ""))
+        name.append(h("input.name-input", {"props": {"type": "text", "value": feature["name"], "id": i, "data-id": feature.id}}, ""))
         value.append(h("label", {"attrs": {"for": i + "-value"}}, "Value:"))
         value.append(h("input.value-input", {"props": {"type": "text", "value": feature["value"], "id": i + "-value"}}, ""))
 
-        content.append(split_line2(name, value))
+        content.append(split_line2(name, value, feature.id))
     content.append(h("button", {"on": {"click": message.msg(message.AddToGenericList, current_labels)}}, "+"))
 
     return content
 
+def explanation_editor(title, current_labels):
+    def split_line2(left, right, labelId):
+            cls = "flex.two{}".format(".double-list-row")
+            isId = {"attrs": {"data-id": labelId}} if labelId >= 0 else {}
+            return h("div.{}".format(cls), isId, [
+                h("div.four-fifth", {}, left), h("div.fifth", {}, right)])
+
+    content = [h("p", {}, title)]
+    for i, explanation in enumerate(current_labels()):
+        language = []
+        value = []
+        language.append(h("label", {"attrs": {"for": i}}, "Language:"))
+        language.append(h("input.language-input", {"props": {"type": "text", "value": explanation["language"], "id": i}}, ""))
+        value.append(h("label", {"attrs": {"for": i + "-value"}}, "Value:"))
+        value.append(h("input.value-input", {"props": {"type": "text", "value": explanation["value"], "id": i + "-value"}}, ""))
+
+        content.append(split_line2(value, language, explanation.id))
+    content.append(h("button", {"on": {"click": message.msg(message.AddToGenericList, current_labels)}}, "+"))
+
+    return content
+
+
+
 def label_list_editor(current_labels, add_label_message_class):
-    def split_line3(left, center, right, is_llr=True):
+    def split_line3(left, center, right, labelId, is_llr=True):
+        isId = {"attrs": {"data-id": labelId}} if labelId >= 0 else {}
         cls = "flex.three{}".format(".label-list-row" if is_llr else "")
-        return h("div.{}".format(cls), {}, [
+        return h("div.{}".format(cls), isId, [
             h("span.third", {}, left), h("span.third", {}, center), h("span.third", {}, right)])
 
-    def dropdown_right(label_type, label):
+    def dropdown_right(label_type, label, index):
         left = h("span.label-type", {}, label_type)
 
         options = [h("option", {}, [])]
@@ -86,17 +114,16 @@ def label_list_editor(current_labels, add_label_message_class):
                   {"props": {"type": "text", "value": right_value, "placeholder": "drugo"}},
                   [])
 
-        return split_line3(left, center, right)
+        return split_line3(left, center, right, index)
 
     content = []
     kontrastivno = False
-    for key, value in current_labels:
+    for key, value, idx in current_labels:
         # we will show kontrastivno a bit differently
         if value == "kontrastivno":
             kontrastivno = True
             continue
-
+        content.append(dropdown_right(key, value, (idx if idx >= 0 else -1)))
-        content.append(dropdown_right(key, value))
 
     # add a way to get new element to add to tag list
     def get_new_label_type():

src/view/modals.py

@@ -19,10 +19,9 @@ def edit_translation(translation, parent, cluster_idx, num_clusters, cls):
 
     # first line: transalation itself
     content.extend([
-        split_line2("Prevedek:",
+        split_line2("Prevedek:", h("textarea#etv", {"props": {"value": translation.translation}}, ""))])
-                    h("textarea#etv", {"props": {"value": translation.translation}}, "")),
+
-        split_line2("Razlaga:",
+    content.extend(explanation_editor("Razlage:", lambda: translation.explanationList))
-                    h("textarea#ete", {"props": {"value": translation.explanation}}, ""))])
 
     # cluster number
     options = [h("option", {"props": {"selected": idx == cluster_idx}}, str(idx + 1)) for idx in range(num_clusters + 1)]
@@ -41,7 +40,9 @@ def edit_sense_label(sense):
 
 def edit_example(example, sense):
     example_original = example
-    example = example_original.copy()
+    # example = example_original.deepcopy()
+    # example = copy.deepcopy(example)
+    # example.original_xml = example_original.original_xml.cloneNode(True)
 
     def role_msg(idx, role):
         return message.msg(message.ExampleRoleChange, example_original, idx, role)
@@ -101,6 +102,7 @@ def edit_variants(entry):
 
 def edit_homonymy(entry):
     hget = lambda: entry.copy().homonymy
+    console.log(hget)
     content = homonymy_editor("Homonymy", hget)
     return modal_template(content, "Add or remove homonymy features", (message.EditHomonymy,), (message.DeleteHomonymy,))
 
@@ -117,7 +119,7 @@ def edit_entry_labels(entry):
 
 
 def edit_sense_definition(sense):
-    return modal_template(question("Edit sense definition", sense.definition["indicator"]), "Sense definition", (message.EditSenseDefinition, sense))
+    return modal_template(question("Edit sense definition", sense.definitions[0].value), "Sense definition", (message.EditSenseDefinition, sense))
 
 
 def edit_comment(comment):
@@ -136,7 +138,7 @@ def do_chosen_examples(example_list, entry):
 
     options = [h("p", {}, "Choose sense for examples")]
     for idx, sense in enumerate(entry.senses):
-        text = "{}: {}".format(idx + 1, sense.definition["indicator"])
+        text = "{}: {}".format(idx + 1, sense.definitions[0].value)
         id_ = "choose-example-{}".format(idx)
 
         props = {"type": "radio", "name": "choose-example"}
@@ -186,6 +188,6 @@ def ske_list(search_term, data, page_num, senses, ske_kinds):
         h("div.flex.three", {}, [
             h("span.third", {}, "Vstavi v:"),
             h("select#ske-sense-select.two-third", {}, [ h("option", {}, "{} {}".format(
-                idx + 1, sense.definition["indicator"])) for idx, sense in enumerate(senses)])])]
+                idx + 1, sense.definitions[0].value)) for idx, sense in enumerate(senses)])])]
 
     return modal_template(contents, "SKE", (message.SkeInsert, data))